Repository navigation
Correct DH parameter and derive handling - #244
Closed
aidangarske wants to merge 8 commits into
Closed
aidangarske wants to merge 8 commits into
aidangarske wants to merge 8 commits into
Conversation
aidangarske
force-pushed
the
fenrir-fixes-8365
branch
from
October 15, 2026 18:23
2fc7a31 to
5a67b13
Compare
aidangarske
force-pushed
the
fenrir-fixes-8365
branch
from
October 15, 2026 23:03
5a67b13 to
fe6e531
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #244
Scan targets checked: wolfengine-src, wolfengine-bugs
Not reviewed (no scan target covers them): .gitignore, README.md, openssl_patches/1.0.2h/tests/fips/dhtest_102h.patch, openssl_patches/1.1.1b/tests/fips/dhtest_111b.patch, test-openssl-version.sh, test/include.am
Coverage: 2 of 3 in-scope changed file(s) opened by the reviewer; not opened: test/test_dh_alloc.c
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-8365- ad050a1 - Named DH groups now preserve an absent q parameter.F-10145- 8622975 - DH now releases the RNG mutex only after successful locking.F-11318- 01f5493 - Padded DH derivation now writes a modulus-sized result.F-12253- e52cf4f - DH padding controls now normalize their input consistently.F-12255- 4e08b1b - DH parameter refresh now clears a stale q value.F-12290- e6aa061 - DH parameter generation now verifies the generated generator.F-13043- 3ca0402 - DH now allocates the correct object size, with an isolated allocation-test fixture.F-13068- 2fc7a31 - Legacy DH parameter handling now validates prime lengths.