Skip to content

Correct DH parameter and derive handling - #244

Closed
aidangarske wants to merge 8 commits into
wolfSSL:masterfrom
aidangarske:fenrir-fixes-8365
Closed

aidangarske wants to merge 8 commits into
wolfSSL:masterfrom
aidangarske:fenrir-fixes-8365

Conversation

@aidangarske

Copy link
Copy Markdown
Member

F-8365 - ad050a1 - Named DH groups now preserve an absent q parameter.

F-10145 - 8622975 - DH now releases the RNG mutex only after successful locking.

F-11318 - 01f5493 - Padded DH derivation now writes a modulus-sized result.

F-12253 - e52cf4f - DH padding controls now normalize their input consistently.

F-12255 - 4e08b1b - DH parameter refresh now clears a stale q value.

F-12290 - e6aa061 - DH parameter generation now verifies the generated generator.

F-13043 - 3ca0402 - DH now allocates the correct object size, with an isolated allocation-test fixture.

F-13068 - 2fc7a31 - Legacy DH parameter handling now validates prime lengths.

@aidangarske aidangarske self-assigned this Oct 15, 2026

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #244

Scan targets checked: wolfengine-src, wolfengine-bugs
Not reviewed (no scan target covers them): .gitignore, README.md, openssl_patches/1.0.2h/tests/fips/dhtest_102h.patch, openssl_patches/1.1.1b/tests/fips/dhtest_111b.patch, test-openssl-version.sh, test/include.am
Coverage: 2 of 3 in-scope changed file(s) opened by the reviewer; not opened: test/test_dh_alloc.c

Fenrir result: Approved ✅

No new issues found in the changed files.

Advisory only — this automated result does not count as a GitHub approval.

Review tier: Lite

@aidangarske
aidangarske marked this pull request as ready for review October 16, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants